Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Update Sail script to only exit if Main Exits #156

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

mellester
Copy link
Contributor

@mellester mellester commented Jun 7, 2021

This is a small change that should help people who like to run e2e tests in containers defined in there docker-compose or any other short lived container.
This patch changes the behavior of Laravel sail to only shutdown the containers if and only if the main PHP containers goes down.
before this patch if any service defined docker-compose.yaml would shutdown for any reason. so would all other containers upon excuting any sail command

Which meant that if you would try to Debug or restart that one service.
for example if you would like to inspect the logs of that container with for example sail logs <servicename>
it would shutdown all containers because it found a stopped container.
This patch should change this behavior to only stop the stack if the main service goes down

@mellester
Copy link
Contributor Author

Reupload of pull request #102 to this branch on suggestion of @driesvints

@driesvints driesvints changed the title Update Sail script to only exit if Main Exits [1.x] Update Sail script to only exit if Main Exits Jun 7, 2021
@taylorotwell taylorotwell merged commit 5226227 into laravel:1.x Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants