[1.x] Update Sail script to only exit if Main Exits #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change that should help people who like to run e2e tests in containers defined in there docker-compose or any other short lived container.
This patch changes the behavior of Laravel sail to only shutdown the containers if and only if the main PHP containers goes down.
before this patch if any service defined
docker-compose.yaml
would shutdown for any reason. so would all other containers upon excuting anysail
commandWhich meant that if you would try to Debug or restart that one service.
for example if you would like to inspect the logs of that container with for example
sail logs <servicename>
it would shutdown all containers because it found a stopped container.
This patch should change this behavior to only stop the stack if the main service goes down