Add MinIO to sail:install Command #128
Conversation
|
We would likely need documentation on how to actually use MinIO with Laravel's filesystem layer. |
|
@taylorotwell I can take a shot at an accompanying PR to the laravel/docs repo today |
src/Console/InstallCommand.php
Outdated
| if (in_array('minio', $services)) { | ||
| $environment .= "\nMINIO_ROOT_USER=sail"; | ||
| $environment .= "\nMINIO_ROOT_PASSWORD=password\n"; | ||
| } |
There was a problem hiding this comment.
Is it necessary to inject anything in the environment file at all? Why not just have default values in the docker-compose.yml file?
There was a problem hiding this comment.
Not required, no. I can move the sail/password defaults to the stub file.
Documentation PR here: laravel/docs#7060 |
|
One last thought... With the MinIO Client, I can add an entry to the stub to auto-create a default bucket as well. This may overcomplicate its maintenance though, it's very simple to create the bucket via the web interface as it is. |
* add minio support * move default values to minio stub * Update InstallCommand.php Co-authored-by: Taylor Otwell <[email protected]>
This PR add support for MinIO (GitHub) to Sail during the install process. It includes a
minio.stubfile to be included in the finaldocker-compse.ymlfile and updates to theInstallCommand.MinIO is an S3 compatible object storage service and is a great compliment to the Laravel development experience so you don't have to use dev S3 buckets.