[1.x] Correctly dispatches presence events #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #213
The fixes introduced all occur when a user is logged in to a single account, but connected to Reverb in multiple tabs or browswers.
The
subscription_succeededevent should contain a unique list of connected user IDs.The
member_addedevent should only be dispatched the first time a user connects to the channel (e.g. the first browser tab).The
member_removedevent should only be dispatched when the user no longer has any connections remaining (e.g. closed all tabs).Details can be found in the Pusher spec.