Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix spelling errors #131

Merged
merged 1 commit into from
Apr 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function subscribe(Connection $connection, ?string $auth = null, ?string
}

/**
* Deteremine whether the given authentication token is valid.
* Determine whether the given authentication token is valid.
*/
protected function verify(Connection $connection, ?string $auth = null, ?string $data = null): bool
{
Expand Down
2 changes: 1 addition & 1 deletion src/Protocols/Pusher/Http/Controllers/Controller.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ abstract class Controller
protected ?Application $application = null;

/**
* Active chnnels for the application.
* Active channels for the application.
*/
protected ?ChannelManager $channels = null;

Expand Down
2 changes: 1 addition & 1 deletion tests/FakeConnection.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class FakeConnection extends BaseConnection
use GeneratesIdentifiers;

/**
* Messages reveived by the connection.
* Messages received by the connection.
*
* @var array<int, string>
*/
Expand Down
6 changes: 3 additions & 3 deletions tests/Feature/Protocols/Pusher/Reverb/ServerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -141,21 +141,21 @@
$connection->assertReceived('{"event":"App\\\\Events\\\\TestEvent","data":"{\"foo\":\"bar\"}","channel":"presence-cache-test-channel"}');
});

it('can receive a cach missed message when joining a cache channel with an empty cache', function () {
it('can receive a cache missed message when joining a cache channel with an empty cache', function () {
$connection = connect();
subscribe('cache-test-channel', connection: $connection);

$connection->assertReceived('{"event":"pusher:cache_miss","channel":"cache-test-channel"}');
});

it('can receive a cach missed message when joining a private cache channel with an empty cache', function () {
it('can receive a cache missed message when joining a private cache channel with an empty cache', function () {
$connection = connect();
subscribe('private-cache-test-channel', connection: $connection);

$connection->assertReceived('{"event":"pusher:cache_miss","channel":"private-cache-test-channel"}');
});

it('can receive a cach missed message when joining a presence cache channel with an empty cache', function () {
it('can receive a cache missed message when joining a presence cache channel with an empty cache', function () {
$connection = connect();
subscribe('presence-cache-test-channel', connection: $connection);

Expand Down
4 changes: 2 additions & 2 deletions tests/ReverbTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public function signedRequest(string $path, string $method = 'GET', mixed $data
/**
* Send a POST request to the server.
*/
public function postReqeust(string $path, ?array $data = [], string $host = '0.0.0.0', string $port = '8080', string $appId = '123456'): PromiseInterface
public function postRequest(string $path, ?array $data = [], string $host = '0.0.0.0', string $port = '8080', string $appId = '123456'): PromiseInterface
{
return $this->request($path, 'POST', $data, $host, $port, $appId);
}
Expand All @@ -175,7 +175,7 @@ public function signedPostRequest(string $path, ?array $data = [], string $host
$string = "POST\n/apps/{$appId}/{$path}\n$query";
$signature = hash_hmac('sha256', $string, 'reverb-secret');

return $this->postReqeust("{$path}?{$query}&auth_signature={$signature}", $data, $host, $port, $appId);
return $this->postRequest("{$path}?{$query}&auth_signature={$signature}", $data, $host, $port, $appId);
}

/**
Expand Down
Loading