[1.x] Fixes incorrect user_count on presence channels #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurPatriot
changed the title
joedixon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. user_count on get channels request
$pusher->getChannels(['filter_by_prefix' => 'presence-', 'info' => 'user_count']);return wrong number foruser_count.If we check Pusher documentation we will see -
user_countis number of distinct users currently subscribed to this channel (a single user may be subscribed many times, but will only count as one). Souser_countmust return only unique users count, not connections count.2. users list on get presence users request
$pusher->getPresenceUsers('presence-channel-id');return wrong list of users with duplicates for each connection. If we check Pusher documentation - fetch user IDs of user currently subscribed to a presence channel. Here must be only unique users, not connections.Resolves #130