[1.x] Re-subscribes to the scaling channel when the underlying connec…

…tion is lost (#251)

* Re-subscribe to the scaling channel when the connection drops

* add tests

* Update RedisPubSubProvider.php

---------

Co-authored-by: Taylor Otwell <[email protected]>

src/Servers/Reverb/Publishing/RedisPubSubProvider.php

@@ -56,6 +56,12 @@ public function subscribe(): void
         $this->subscribingClient->on('message', function (string $channel, string $payload) {
             $this->messageHandler->handle($payload);
         });
+
+        $this->subscribingClient->on('unsubscribe', function (string $channel) {
+            if ($this->channel === $channel) {
+                $this->subscribingClient->subscribe($channel);
+            }
+        });
     }
 
     /**

tests/Unit/Servers/Reverb/Publishing/RedisPubSubProviderTest.php

@@ -0,0 +1,44 @@
+<?php
+
+use Clue\React\Redis\Client;
+use Laravel\Reverb\Servers\Reverb\Contracts\PubSubIncomingMessageHandler;
+use Laravel\Reverb\Servers\Reverb\Publishing\RedisPubSubProvider;
+use Laravel\Reverb\Servers\Reverb\Publishing\RedisClientFactory;
+use React\EventLoop\LoopInterface;
+
+it('resubscribes to the scaling channel on unsubscribe event', function (){
+
+    $channel = "reverb";
+    $subscribingClient = Mockery::mock(Client::class);
+
+    $subscribingClient->shouldReceive('on')
+        ->with('unsubscribe', Mockery::on(function ($callback) use ($channel) {
+            $callback($channel);
+            return true;
+        }))->once();
+
+    $subscribingClient->shouldReceive('on')
+        ->with('message', Mockery::any())
+        ->zeroOrMoreTimes();
+
+    $subscribingClient->shouldReceive('subscribe')
+        ->twice()
+        ->with($channel);
+
+
+    $clientFactory = Mockery::mock(RedisClientFactory::class);
+
+    // The first call to make() will return a publishing client
+    $clientFactory->shouldReceive('make')
+        ->once()
+        ->andReturn(Mockery::mock(Client::class));
+
+    $clientFactory->shouldReceive('make')
+        ->once()
+        ->andReturn($subscribingClient);
+
+    $provider = new RedisPubSubProvider($clientFactory, Mockery::mock(PubSubIncomingMessageHandler::class), $channel);
+    $provider->connect(Mockery::mock(LoopInterface::class));
+
+    $provider->subscribe();
+});