Check if channel variable isn't null when passed as a filter on chann…

…els() method in ArrayChannelManager
laravel · Dec 27, 2024 · 424ea55 · 424ea55
1 parent 9469732
commit 424ea55
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Protocols/Pusher/Managers/ArrayChannelManager.php b/src/Protocols/Pusher/Managers/ArrayChannelManager.php
@@ -134,7 +134,7 @@ public function channels(?string $channel = null): Channel|array|null
     {
         $channels = $this->applications[$this->application->id()] ?? [];
 
-        if ($channel) {
+        if (isset($channel)) {
             return $channels[$channel] ?? null;
         }
 

diff --git a/tests/Unit/Protocols/Pusher/EventTest.php b/tests/Unit/Protocols/Pusher/EventTest.php
@@ -38,6 +38,19 @@
     ]);
 });
 
+it('can subscribe to an empty channel', function () {
+    $this->pusher->handle(
+        $this->connection,
+        'pusher:subscribe',
+        ['channel' => '']
+    );
+
+    $this->connection->assertReceived([
+        'event' => 'pusher_internal:subscription_succeeded',
+        'data' => '{}',
+    ]);
+});
+
 it('can unsubscribe from a channel', function () {
     $this->pusher->handle(
         $this->connection,