[9.x] Added provider check to cookie authentication

[billriess]

This PR attempts to add provider validation for cookie-based authentication. This needs to be tested locally, as it may re-introduce #1243

[RahulDey12]

I have opened a new PR regarding this #1283

[taylorotwell]

I have two PRs open for this now but neither has any description of what is being fixed or addressed. We need a lot more detail 😅

[RahulDey12]

@taylorotwell I've Updated the description of #1283

[taylorotwell]

OK. I don't understand. Are you offering that PR as an alternative to this? Is it complimentary to this?

[taylorotwell]

@billriess also need more explanation on this. What is it fixing? How does it fix it? Why might it re-introduce a bug?

[taylorotwell]

I'll wait for @RahulDey12 to submit a PR with passing tests.

[billriess]

Sorry, @taylorotwell I submitted this quickly because @driesvints asked me to look into it and I was a bit rushed on time. I can update the description later. This should be an easy fix but just needed manual testing which I didn't have time to set up originally.

[driesvints]

I'll try to take a look at this myself as soon as I have Cashier Paddle wrapped up.

[driesvints]

I'm gonna let this one go. We've only gotten one request to add multi auth to the fresh api token middleware so I don't think it's worth investing time into it atm.

[RahulDey12]

Do you have any plan to achieve this then I can do it.

[driesvints]

Not at this time sorry.

[billriess]

@driesvints did you run into issues when you tested it?

[driesvints]

I haven't tested this sorry. Wanted to focus on other things. We've only gotten one request so far for this so we didn't feel that it would warrant to put in more time at this moment.

[billriess]

Ok, no problem. Just wanted to make sure it wasn't causing any issues.

…

On Sat, Jun 6, 2020, 5:39 AM Dries Vints ***@***.***> wrote: I haven't tested this sorry. Wanted to focus on other things. We've only gotten one request so far for this so we didn't feel that it would warrant to put in more time at this moment. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1282 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA75DXR2PY4A55FZRXP46XDRVIFFTANCNFSM4NJYZGLA> .