Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create composer.lock as minimun required platform #69

Closed
wants to merge 1 commit into from
Closed

Create composer.lock as minimun required platform #69

wants to merge 1 commit into from

Conversation

gmsantos
Copy link

@gmsantos gmsantos commented Jul 27, 2017

Create composer.lock emulating minimum PHP version for Laravel 5.4 avoid errors like the reported here laravel/framework#20214 , keeps the lock file for faster installations and allow to relax dependencies constraint again.

@taylorotwell is this .sh still used to generate http://cabinet.laravel.com/ files? It's not used on NewCommand as far I know.

Related:
https://getcomposer.org/doc/03-cli.md#config
https://getcomposer.org/doc/06-config.md#platform
laravel/framework#20214
laravel/framework#20241 (comment)
#68

@lk77
Copy link

lk77 commented Jul 27, 2017

i don't think it's the solution, because it force users of php ~7.0 to do a composer update to have most recent packages. i think we need a php5.x-latest.zip and a php7.x-latest.zip

@gmsantos
Copy link
Author

They will not get the latest only for packages that require php >= 7.0. All the other packages will came with the most recent version defined by the constraint.

Having a cabinet package by PHP version will require minor versions too (php7.1-latest.zip, php7.2-latest.zip), even patch because this requirement is in package domain. It's a nice solution but depends to update the package builder, modify the NewCommand and release a new tag for Laravel Installer.

With this approach we only have to include a new line on the .sh package builder. The drawback is to do a composer update on newer PHP versions (PHP 7.0+) vs breaking a supported version (PHP 5.6 with Laravel 5.4). At least all scenarios will have a up and running Laravel project.

@taylorotwell
Copy link
Member

I'm not sure this is needed anymore since we're requiring a more specific version of the inflector now?

@taylorotwell
Copy link
Member

/cc @themsaid

@lk77
Copy link

lk77 commented Jul 27, 2017

yes it's actually fixed, but the problem remain, if another package drop the support of php5.6, it will happens again.

@themsaid
Copy link
Member

@taylorotwell yes I believe this isn't needed anymore

@gmsantos gmsantos deleted the patch-1 branch July 27, 2017 21:48
@taylorotwell
Copy link
Member

Added this to the laravel build server.

@gmsantos
Copy link
Author

gmsantos commented Aug 7, 2017

@taylorotwell @themsaid can laravel/framework#20227 be reverted?

Also if zipper.sh isn't used anymore I suggest to remove it from installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants