Prevent infinite loop when forgetting failed jobs (#1429)

laravel · Apr 25, 2024 · c918b06 · c918b06
1 parent 0f08459
commit c918b06
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Console/ForgetFailedCommand.php b/src/Console/ForgetFailedCommand.php
@@ -34,14 +34,16 @@ public function handle(JobRepository $repository)
             $totalFailedCount = $repository->totalFailed();
 
             do {
-                collect($repository->getFailed())->pluck('id')->each(function ($failedId) use ($repository): void {
+                $failedJobs = collect($repository->getFailed());
+
+                $failedJobs->pluck('id')->each(function ($failedId) use ($repository): void {
                     $repository->deleteFailed($failedId);
 
                     if ($this->laravel['queue.failer']->forget($failedId)) {
                         $this->components->info('Failed job (id): '.$failedId.' deleted successfully!');
                     }
                 });
-            } while ($repository->totalFailed() !== 0);
+            } while ($repository->totalFailed() !== 0 && $failedJobs->isNotEmpty());
 
             if ($totalFailedCount) {
                 $this->components->info($totalFailedCount.' failed jobs deleted successfully!');