use func_get_args to pass array_prepend call through to Arr::prepend … #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently calling
array_prepend()
with a missing third ($key
) argument callsArr::prepend()
with three arguments, the third being the defaultnull
value from thearray_prepend()
definition. However,Arr::prepend()
usesfunc_num_args()
to check if the third argument is set. This leads to the element being prepended with an empty key (and any subsequent calls ofarray_prepend()
(without supplying a third argument) overwriting the inserted element).Using
...func_get_args()
leads to the third argument of theArr::prepend()
call not being set if no third argument is supplied toarray_prepend(),
thus enabling correct handling of numeric indices.