[5.0] Illuminate\Foundation\Artisan is no longer needed in after the HTTP Kernel refactors.

[crynobone]

Signed-off-by: crynobone [email protected]

[GrahamCampbell]

👍 Nice. :)

[bart]

I'm not sure if this is the right solution because calling

Artisan::call('migrate', ['--seed' => true]);

from inside a controller now returns

InvalidArgumentException in Application.php line 549:
Command "migrate" is not defined.

[crynobone]

@bart I would argue that using Artisan command from within a controller is a hack and (personally feel) at some point should be stopped. You should actually using the Illuminate\Database\Migrations\Migrator directly.

Why is the code failing? because MigrationServiceProvider is deferred, and only inside console environment does all deferred service provider is preloaded.

[bart]

@crynobone Thanks a lot for your explanation. I already figured out that the ServiceProvider doesn't load the migrate command. So using Illuminate\Database\Migrations\Migrator will be the right choice. But this also means, that using Artisan:call('mycommand') from outside the CLI wouldn't work anymore, right?

[crynobone]

@bart the trick with Illuminate\Foundation\Artisan it just that it forced deferred service provider to be loaded, before loading Illuminate\Console\Artisan which fire artisan.start event. https://github.com/laravel/framework/pull/6178/files#diff-3915f7c1d5906f98625395fd56d70a3fL41.

[bart]

And that means calling Artisan::call() from inside a controller wouldn't be possible anymore for non-default (registered) Artisan command, right? It's no problem as long as you can call things directloy by class methods. But it was a fancy simple way which will be lost. Not a big thing but a fact people, who are switching to L5, should know. What do you think?

[bart]

Could you please give an example how to call a command (migrate --seed) from a controller now? Didn't really get it :(

[crynobone]

$app = app();

$app->make('DatabaseSeeder')->setContainer($app)->run();

[bart]

Hmm I think I will wait for a comment of @taylorotwell. Maybe he won't kick the Artisan::call(), too. Your example seeds the database but how to migrate it? Sth like $app->make('Migrator')->setContainer($app)->run();.

Sorry for these questions. I know it's not a support forum but really want to know how to do it now and in future.

[crynobone]

What is so hard with:

$app = app();
$migrator = $app->make('migrator'); // Illuminate\Database\Migrations\Migrator
$migrator->run($app->databasePath().'/migrations');

Or go with the hackish way (should work in theory):

App::loadDeferredProviders();
Artisan::call('migrate', ['--seed' => true]);

[bart]

Nothing. It simply is more than Artisan::call('migrate --seed');

First sentence of Laravel Philosophy: Laravel is a web application framework with expressive, elegant syntax.

Maybe this elegant syntax will be lost in some parts with L5 which would be a real pity.

[bart]

When I'm calling Artisan::call('migrate --seed'); after your last commit db577cd I'm still getting

InvalidArgumentException in Application.php line 549:
Command "migrate --seed" is not defined.

[crynobone]

Artisan::call('migrate', ['--seed' => true]); !== Artisan::call('migrate --seed');

[GrahamCampbell]

@bart Please continue this on the forums.

[bart]

For sure I will and just for your information @crynobone: It's still not working:

ContextErrorException in QuestionHelper.php line 112:
Notice: Use of undefined constant STDIN - assumed 'STDIN'

My current solution is running the migrate command using Symfonys Process class.

[crynobone]

@bart see #4721 (issue with STDIN exist even in 4.2 due to update on symfony/console, which all artisan command depends on).

[crynobone]

Latest commit show that @taylorotwell explicitly load deferred providers from within Illuminate\Foundation\Console\Kernel, so I'm not sure if this still relevant (only useful if Laravel still want to support calling "artisan" from non-console environment).

[crynobone]

After discussion with @taylorotwell on irc, he said to removed this line. Latest commit contain rebased on solve a merge conflict in console kernel.

[bart]

Which means that the hacky way using Artisan:call() won't be supported in L5 anymore. Nice to know. Thanks sir!

[GrahamCampbell]

@taylorotwell Without this patch, my test suites are broken for some of my laravel 5 branches: https://travis-ci.org/GrahamCampbell/Laravel-Core/jobs/39004380.

[crynobone]

@taylorotwell has made the change upstream. Now just need to remove the dead code in ArtisanServiceProvider.