Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Refactor and add remaining test cases for the DatabaseFailedJobProviderTest class #53409

Conversation

kevinb1989
Copy link
Contributor

This PR is very similar to #53408, I would like to refactor and add test cases for remaining methods of the Illuminate\Queue\Failed\DatabaseFailedJobProvider class.

This includes:

  • Extract the following code snippets to new methods:
    • creating a database instance
    • creating a provider instance
    • inserting records to the failed_jobs table
  • Create test cases for the following methods:
    • ids
    • all
    • find
    • forget
    • prune

@taylorotwell taylorotwell merged commit ca0617a into laravel:11.x Nov 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants