Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] Validate UUID version 2 and max #53368

Merged

Conversation

shaedrich
Copy link

@shaedrich shaedrich commented Oct 31, 2024

Improves #53341

Symfony/uid doesn't implement version 2, therefore, using ramsey/uuid was necessary.

@shaedrich shaedrich changed the title Validate UUID version 2 and max [12.x] Validate UUID version 2 and max Oct 31, 2024
@NickSdot
Copy link
Contributor

NickSdot commented Nov 1, 2024

Illuminate components are installable stand-alone. ramsey/uuid is only suggested in illuminate/support/composer.json, while it is directly required in illuminate/queue/composer.json.

Question: given your changes, should illuminate/validation/composer.json now also directly require it?

to be able to use it for UUID version constraint validation
@shaedrich
Copy link
Author

@NickSdot Good catch! 👍🏻 I added it to the suggestions, too, since \Illuminate\Support has it there as well. Let's see, what Taylor says

@taylorotwell taylorotwell merged commit e4fcc78 into laravel:master Nov 1, 2024
31 checks passed
@shaedrich shaedrich deleted the validate-uuid-version-2-and-max branch November 1, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants