[11.x] Fix integrity constraint violation on failed_jobs_uuid_unique #53264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
I wonder if this would be more easily solved with just a static variable in the |
|
That's what I did first! I'm happy to have another look at that. |
This reverts commit ff22f3a.
This reverts commit 2086b6c.
…_unique (laravel#53230)" This reverts commit 51a0eba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53230
Listeners are bound each time
Artisan::call('queue:work')is called. That results in:DatabaseUuidFailedJobProvideris used, then an integrity constraint violation is thrown due to multiple calls tologFailedJob().Static var prevents listeners being bound multiple times within application life cycle.