Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] PHPDoc Improvements #53139

Merged
merged 1 commit into from
Oct 13, 2024
Merged

[11.x] PHPDoc Improvements #53139

merged 1 commit into from
Oct 13, 2024

Conversation

xurshudyan
Copy link
Contributor

This PR improves the docblocks in the Builder class:

Updates the $orders and $unionOrders properties to indicate they can also accept null.

Adds \Illuminate\Contracts\Database\Query\Expression as a valid type for the $table parameter in the newJoinClause and newJoinLateralClause methods.

@taylorotwell taylorotwell merged commit 964ef32 into laravel:11.x Oct 13, 2024
33 checks passed
timacdonald pushed a commit to timacdonald/framework that referenced this pull request Oct 15, 2024
@xurshudyan @timacdonald
Update docblocks (laravel#53139)
ff65fa0 
Co-authored-by: Xurshudyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xurshudyan @taylorotwell