-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Auto-register commands in routes/console.php
#52867
Merged
taylorotwell
merged 1 commit into
laravel:11.x
from
SamuelNitsche:auto-register-console-routes
Sep 22, 2024
Merged
[11.x] Auto-register commands in routes/console.php
#52867
taylorotwell
merged 1 commit into
laravel:11.x
from
SamuelNitsche:auto-register-console-routes
Sep 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelNitsche
changed the title
Auto-register commands in
[11.x] Auto-register commands in Sep 20, 2024
routes/console.php
routes/console.php
@taylorotwell when there are both commands in Luckily, I have a preparation Envoy script before deploying, as I never tested for a command availability. |
Schedules ( |
crynobone
added a commit
that referenced
this pull request
Sep 26, 2024
This reverts commit e216708.
crynobone
added a commit
that referenced
this pull request
Sep 26, 2024
This reverts commit e216708.
@SamuelNitsche this PR has been reverted due to breaking change with existing application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on route registration in a Laravel app, I noticed some inconvenience when using the
using
callback of thewithRouting
method.In particular, the main issue was that commands defined in
routes/console.php
were not registered anymore. When checking the docs, I saw that there is a way to register commands using thewithCommands
method.However, to achieve the same behaviour of the
withRouting
method you must pass theroutes/console.php
file as a parameter.I think the DX could be improved by checking if the
routes/console.php
file exists and if so, registering all commands (including their schedule) automatically. This should be a good sensible default since theroutes/console.php
file is the default way to register commands in Laravel 11.So before:
and after:
I couldn't find any existing tests for the
ApplicationBuilder
so I decided to also not add any in this PR.