Add result shorthands for Process
fakes
#52840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new shorthands for faking process results in tests. The first is a shorthand to simply set the exit code. The second is a shorthand to throw an exception.
Note: while the latter is not common as it is only possible for the underlying Symfony
Process
to throw aRuntimeException
. This path was hard to test unless a fake process can throw an exception - basically you had to single out the command in a callback, thenthrow
. This is cleaner and can be used to test other paths, such as process timeout, etc.