Fix: Unreachable action buttons in notification template when using "align" prop with "left" or "right". #52758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the alignment of action buttons in the notification template when the align prop is used.
The option to pass align as a prop was introduced in PR #45362. When set to
left
orright
, the action button becomes unreachable as it gets overlaid by a following text element:(Screenshot of the PasswordReset notification rendered in Google Chrome; the issue was also reproducible in multiple mail clients.)
This occurs because applying
align="left"
to a table element basically adds afloat: left
.Steps to reproduce:
email.blade.php
file (php artisan vendor:publish --tag=laravel-notifications
).align="left"
to the<x-mail::button>
.Proposed fix:
We could address this by either removing the inheritance of the align prop for the table in this line and always setting the alignment to center.
However, I propose unsetting the float for the
.action
class in the default theme, which feels like a less intrusive solution.