Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix $fail closure type in docblocks for validation rules #52644

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

bastien-phi
Copy link
Contributor

Fixes the closure type as defined in

$this->invokable->{$method}($attribute, $value, function ($attribute, $message = null) {
$this->failed = true;
return $this->pendingPotentiallyTranslatedString($attribute, $message);
});

@bastien-phi bastien-phi changed the title Fix $fail closure type in docblocks for validation rules [11.x] Fix $fail closure type in docblocks for validation rules Sep 4, 2024
@taylorotwell taylorotwell merged commit 769f00b into laravel:11.x Sep 4, 2024
31 checks passed
@bastien-phi bastien-phi deleted the fix_fail_closure_type branch September 4, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants