Checking availability before calling Log::flushSharedContext() method #52470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: minor bug fix
Location:
Illuminate\Queue\QueueServiceProvider::registerWorker()
There are some edge cases where
$app['log']
may not containflushSharedContext()
method.In the next statement, in the case of
withoutContext()
(line 204 ofQueueServiceProvider
), it's checking for method existence. Similarly, I think i'd be nice to check method existence before calling this function too.Background
I was trying to use
Queue
in a Laravel Zero app without installinglog
component. And was getting this error:Then I checked and found that, the
Psr\Log\NullLogger
actually don't have this method.