[11.x] Support attributes in app()->call()
#52428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a follow-up of #51934. It adds support for the same features on
app()->call()
, therefore supporting parameters injected to routes,handle
methods, etc.Important note
Since the resolution of the dependencies of closures happens outside of the container itself (in
BoundMethod
), we don't have access to methods that are needed for this to work.Specifically:
resolveFromAttribute
fireAfterResolvingAttributeCallbacks
These cannot be copied to
BoundMethod
because they depend on properties of the container (contextualAttributes
andafterResolvingAttributeCallbacks
).I couldn't find a clean solution for this that didn't involve a bigger refactor. For now, I made these methods public, but the pull request cannot be merged as-is, as we do not want them to be available to the public API.
Possible solutions
BoundMethod#addDependencyForCallParameter
to useContainer#resolveDependencies
, but it doesn't support the$parameters
array and its behavior is slightly different.BoundMethod
could be integrated into theContainer
itself (but we can't get rid of the class entirely, it is not marked as@internal
, projects like Livewire use it).Any suggestion?