Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Test Improvements #52402

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[11.x] Test Improvements #52402

merged 1 commit into from
Aug 7, 2024

Conversation

crynobone
Copy link
Member

No description provided.

Signed-off-by: Mior Muhammad Zaki <[email protected]>
$this->assertFilenameExists('app/Mail/MyFooMail.php');
$this->assertFilenameExists('resources/views/mail/my-foo-mail.blade.php');
$this->assertFilenameExists('app/Mail/FooMail.php');
$this->assertFilenameExists('resources/views/mail/foo-mail.blade.php');
Copy link
Member Author

@crynobone crynobone Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion was incorrect since published files from the previous test weren't cleared correctly.

@crynobone crynobone marked this pull request as ready for review August 6, 2024 17:21
@taylorotwell taylorotwell merged commit 5ae7da1 into 11.x Aug 7, 2024
32 checks passed
@taylorotwell taylorotwell deleted the test-improvements branch August 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants