-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Add contextual attributes to resolve drivers #52265
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
I think probably the case could be made for having attributes for most of the built-in driver based stuff... wonder if we should add cache and auth attributes to this PR? |
@taylorotwell I've added cache, database and log attributes to this PR. @ollieread mentioned he had plans for auth on the implementation PR, and he's knowledgeable about multi tenancy, so I'll leave those to him if that's ok. |
If you have time to do it now, feel free to do so, especially if you're already doing it. I was going to add a |
@ollieread I've added an Authed and Guard attribute. Hopefully they look sensible. |
Looks good to me! Good job 👍 |
I work on an app where we pass multiple filesystems to various controllers and commands, and currently we have to register a contextual binding for each one to supply the appropriate filesystems.
This PR adds a new
Storage
contextual attribute for resolving storage disks, which can be specified directly on the parameters: