[11.x] allow custom view path when making components #52219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently the `component/` view path is hardcoded into the generator command. while definitely a good default, there can be a need for more custom view paths, depending on each application's specific organization. this change makes it possible to pass a `--path` option to the command, which will override the location of the view file.
|
could someone kick off a rerun of the tests? the failures seem unrelated to my PR. |
|
Hi there. Please rebase this PR as we've fixed the test suite on the 11.x branch. Then mark your PR as ready again. |
|
thanks @driesvints . PR is ready for review. |
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the
component/view path is hardcoded into the generator command. while definitely a good default, there can be a need for more custom view paths, depending on each application's specific organization.this change makes it possible to pass a
--pathoption to the command, which will override the location of the view file.