[11.x] Rename Model::$collection to $collectionClass

[GromNaN]

After #52171, all projects using the package mongodb/laravel-mongodb will be broken. The property $collection is used for years as an alias for $table, as documented in Laravel MongoDB / Eloquent Models.

Would it be possible to choose a different name for the new static property in order to prevent update issues for hundreds of projects.

[GromNaN]

Thank you @taylorotwell

[henzeb]

@taylorotwell, @GromNaN, @calebdw, still not getting why this class parameter is in Model and not in the trait ?

[calebdw]

If the property is defined on the trait, then you would not be able to override it:

https://www.php.net/manual/en/language.oop5.traits.php

If a trait defines a property then a class can not define a property with the same name unless it is compatible (same visibility and type, readonly modifier, and initial value), otherwise a fatal error is issued.

[henzeb]

If the property is defined on the trait, then you would not be able to override it:

https://www.php.net/manual/en/language.oop5.traits.php

If a trait defines a property then a class can not define a property with the same name unless it is compatible (same visibility and type, readonly modifier, and initial value), otherwise a fatal error is issued.

ok, forgot about that, but where would you need that trait for anyway, if it is permanently attached to the Model? one line extra and one line modified doesn't really count as "slimming it down"?

[devfrey]

So now we have $builder and $collectionClass. Can't we rename the former to $builderClass for consistency?

[calebdw]

I'd rather not, the Factory uses $model and the Model uses $factory as well