Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix Component::resolveComponentsUsing test #51988

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[11.x] Fix Component::resolveComponentsUsing test #51988

merged 1 commit into from
Jul 2, 2024

Conversation

seriquynh
Copy link
Contributor

  • \Illuminate\View\Illuminate\View::resolve() accepts array only for now. But the current test pass a string into it.
  • Plus, I added 2 assertions to ensure the resolver callback is executed with the component class name and the given data.

@taylorotwell taylorotwell merged commit 7156183 into laravel:11.x Jul 2, 2024
28 checks passed
@seriquynh seriquynh deleted the fix-test branch July 5, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriquynh @taylorotwell