[11.x] Update tests to ensure mail Message implements the fluent interface pattern #51969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Illuminate\Mail\Message
implements the fluent interface pattern. Each of these methods:from
,sender
,returnPath
,to
,cc
,bcc
,replyTo
,subject
andpriority
must change and return the instance itself. But current tests can be passed if a method return a clone/new static Message instance.Let's take a look at
from
method.I think if a class implements the fluent interface pattern,
assertSame
is the required assertion when writing tests.