Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Add addEventDiscoveryPaths to EventServiceProvider #51896

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

ya-cha
Copy link
Contributor

@ya-cha ya-cha commented Jun 24, 2024

This pull request introduces the capability to append discovery paths to the EventServiceProvider, rather than overwriting the entire array.

In our application, we manage a domain structure where each domain has its own event listeners. Shared Listeners are still in the original location.

In our DomainServiceProvider we iterate through those domains add register views, Livewire components etc. This enhancement allows us to add discovery paths in the DomainServiceProvider without overwriting the existing paths. This way, each domain can register its listeners independently.

Since I did not find tests for the method setEventDiscoveryPaths, I did not add any for the new method.

@ya-cha ya-cha changed the title Add addEventDiscoveryPaths to EventServiceProvider [11.x] Add addEventDiscoveryPaths to EventServiceProvider Jun 24, 2024
@taylorotwell taylorotwell merged commit e4796bc into laravel:11.x Jun 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants