Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Update error page to show GET <path> #51837

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

chu121su12
Copy link
Contributor

This PR update the Request section of the new error page to show GET <path> (without version) as it might be shown in curl instead of currently GET <host>. There are still GET <host> above to the right that hide in small screen.

image

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@chu121su12 chu121su12 marked this pull request as ready for review June 19, 2024 08:33
@taylorotwell
Copy link
Member

What if path returns /?

@chu121su12
Copy link
Contributor Author

You're right, Sorry I missed the condition

@taylorotwell taylorotwell merged commit 7a348b3 into laravel:11.x Jun 20, 2024
28 checks passed
@chu121su12 chu121su12 deleted the patch-3 branch October 16, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants