[11.x] Filter environment variables in ServeCommand #51692
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an old outstanding issue that previously required a
php.ini
adjustment. (#34229)At the moment, the
ServeCommand
does not really filter environment variables that are being passed to the PHP process, but instead it sets them tofalse
.This can lead to issues if the variable is being used by the system and is then set to
false
.Instead of passing the variables as
false
, this PR now filters the env variables and only passes those to the process that are passthrough variables - or all in case--no-reload
is specified.