Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fixes exception rendering #51587

Merged
merged 3 commits into from
May 28, 2024
Merged

[11.x] Fixes exception rendering #51587

merged 3 commits into from
May 28, 2024

Conversation

nunomaduro
Copy link
Member

This pull request addresses two things on #51261:

  • Clears the queries context when jobs are starting and processed;
  • Fixes double rendering, when sometimes, there more than one exception being renderered: like on the controller + on terminable middleware.

@nunomaduro nunomaduro requested a review from taylorotwell May 27, 2024 15:55
@nunomaduro nunomaduro marked this pull request as draft May 27, 2024 16:21
@nunomaduro nunomaduro marked this pull request as ready for review May 27, 2024 16:32
@taylorotwell taylorotwell merged commit 42142ae into 11.x May 28, 2024
31 checks passed
@nunomaduro nunomaduro deleted the fix/queue-clearing branch May 28, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timacdonald timacdonald timacdonald left review comments

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunomaduro @timacdonald @taylorotwell