[11.x] Collection average/avg optimization #51512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes an algorithm improvement for the Collection
avg()
andaverage()
function.The previous code used an inefficient
map+filter+count
, whereas the new implementation does it all at once with a reducer.Algo explanation
[0, 0]
$avg = $reduced[0] / $reduced[1]
Additionally, the function has been moved to the
EnumeratesValues
trait so the lazy collection can also benefit from this optimization. It also works as expected withyield
.Benchmark (gist)