[11.x] Additonal Blade Loop Improvements #51217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
I'll try to review / update the tests this weekend. Wanted to at least push so it could be visible. If anyone has the time feel free to pitch in. |
crynobone
reviewed
Apr 26, 2024
| use InvalidArgumentException; | ||
| use Illuminate\Contracts\Support\Renderable; | ||
| use Illuminate\Contracts\Container\Container; | ||
| use Illuminate\Contracts\View\Factory as FactoryContract; |
There was a problem hiding this comment.
the order of import is alphabetical ascending and not by length.
There was a problem hiding this comment.
Thanks crynobone. I'll adjust it when I go through the failing tests.
|
Going to close this one now. Feel free to resend with passing tests when you have the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using same benchmarking as in #51158
Before:
OPCache Enabled: Enabled
With caching: 164.14968581818
After:
OPCache Enabled: Enabled
With caching: 135.41356454545
Essentially the framework is suffering from a death by 1,000 cuts for anything in a loop. Anything that is repeatable (e.g. Compiler::getCompiledPath) or anything that includes unnecessary indirection (e.g. View::name) should be cleaned up.
Each one of these changes improved performance by ~1-3%. Combined it was ~15-20%.