Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Allow sorting of route:list by multiple columns, ASC and DESC #51205

Closed

Conversation

fgaroby
Copy link
Contributor

@fgaroby fgaroby commented Apr 24, 2024

This PR improves the new route:list multiple columns sort, by allowing ASC or DESC for each factor.

For example, we can do this now :

artisan route:list --sort=domain,uri:DESC

Which first sorts the list by domain column ASC (default value) and then by the uri column DESC.

@driesvints driesvints changed the title allow sorting of route:list by multiple columns, ASC and DESC in the … [11.x] Allow sorting of route:list by multiple columns, ASC and DESC Apr 25, 2024
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants