-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] github actions: test mariadb very latest #51193
Conversation
MariaDB Foundation produce a quay.io image off the latest RC branch. This included only reviewed and tested changes that developers consider finished. To maintain compatibility with important ecosystem projects like Laravel, its important that Laravel's test suite be applied to this testing too. MariaDB would like to find out about any accidental incompatibilities before release for our mutual users' benefit.
I do get the sentiment behind the PR here but right now we're not doing this for any of the other engines either. If we do this I feel like we should do this for all of them or none. Bit torn because this will increase our action count by another 5 checks that'll need to run on every PR. Wondering if it makes sense to add a different |
@driesvints I am also in favour of a nightly build, instead of running the tests on each PR. Note: A quick search showed that MySQL, Postgres and MSSQL not really have "preview" images available or I just couldn't find them. (For MSSQL there is a tag |
@grooverdan an alternative is also, that you run the tests in your environment / repository and simply pull the default/latest laravel framework branch in. You could then also experiment with different charsets e.g. |
I'm not familiar with other DB's offering a nightly binary/container either. Closest I've found is https://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto with "Testing Additional Software", but it means hooking into their buildfarm and postgres compiling as well. I have done the occasional 3rd party test like php in our environment (https://buildbot.mariadb.org/#/builders/237), I just struggle to refamiliarise myself with the build/test/framework when I need to correct test failures (as the build history shows). Happy to summit a nightly github action. Also could extend the existing MariaDB job with a second service on a different port like 3308 (with a port mapping) and having a second execute tests stage (33s) with DB_PORT=3308. Not sure if there is any parallelisation in the Initialize containers step but it could be up to 22 seconds again. Still this is saving 20 seconds on top a duplicated step like this PR. (Oh how I envy a 2 minute test suite 😃 ) |
@grooverdan I went ahead and created a nightly workflow. See #51218 (It is open to the Taylor / Laravel Team which one should be merged) |
Gonna close this one in favour of #51218. Thanks @grooverdan! |
Thank you. |
MariaDB Foundation produce a quay.io image off the latest RC branch. This included only reviewed and tested changes that developers consider finished.
To maintain compatibility with important ecosystem projects like Laravel, its important that Laravel's test suite be applied to this testing too. MariaDB would like to find out about any accidental incompatibilities before release for our mutual users' benefit.
announce doc: https://mariadb.org/new-service-quay-io-mariadb-foundation-mariadb-devel/
(and yes images have got a bit behind recently due to accidential builder change, but will be back soon).