-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Add Prompts textarea
fallback for tests and add assertion tests
#51055
Conversation
I'm not quite sure how to fix the failing tests - I think they're failing because |
I've updated the composer.json to bump the prompts version to at least get the tests passing but not sure if this should be left alone... |
Thanks, @lioneaglesolutions! I've updated the fallback to use Symfony's multiline setting. It doesn't matter so much for test assertions, but the fallbacks are also used for Windows users without WSL. |
Awesome @jessarcher glad I could help. Any thoughts on #51056? |
textarea
fallback for tests and add assertion teststextarea
fallback for tests and add assertion tests
This PR adds a
fallback
for the newtextarea
component in Laravel Prompts, similar to other components. Without this, you can not useexpectsQuestion
when using thetextarea
prompt.Issue
I don't quite understand the underlying
fallbackUsing
behaviour but I do know that if it's missing, it causes the tests to hang.Fixes
Tests
I'm not sure if the tests are the right way to go about this but it's the only way I could validate the fix in the framework. If you remove the new
Textarea::fallbackUsing(...)
and run the new tests, they will hang. I also found some other interesting behaviour when writing those tests but require these to be merged first before I can work on a fix.Additional PR
If this PR is merged, can #51056 please be looked at as well?