[11.x] Name of job set by displayName() must be honoured by Schedule #50961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UPD: added |
SCIF
commented
Apr 8, 2024
| */ | ||
| public function job($job, $queue = null, $connection = null) | ||
| public function job(object|string $job, ?string $queue = null, ?string $connection = null): CallbackEvent |
There was a problem hiding this comment.
I thought it will be better to make the signature properly typed as it can be done with php8.2. On one hand this is a BC for those extending this class. On another hand this is internal class and should not be extended.
Let me know what do you think. In case you consider this is as a major BC break, I would revert back signature as don't want to wait v12 to get this fix.
There was a problem hiding this comment.
Please revert this as we currently do not fully type method signatures in the framework.
SCIF
changed the title
|
Resubmit without changing types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queue jobs could have
displayName()method providing a better naming than just a plain classname. This name is currently honoured by a queue worker but a queue scheduler. This PR fixes this inconsistency