[11.x] Throw exception if named rate limiter and model property do not exist

[mateusjatenee]

Based on what we talked regarding #50818

Handling strict mode is a bit annoying — if you have it set, it'd throw a bit of a cryptic error message since it'd fail with a different error. Another thing is that the array_key_exists solution doesn't deal with custom attributes.
Maybe it's an opportunity to introduce a strict-safe hasAttribute method within Eloquent?

[taylorotwell]

I need to think about this one a bit. There could still be a virtual accessor for maxAttempts.

[mateusjatenee]

@taylorotwell thanks for merging that in. this one should be good to go.

[mateusjatenee]

Not entirely sure why AboutCommandTest is failing on 8.2. Seems unrelated as it's happening to other PRS too, but I'm seeing if I can figure out what's going on

[driesvints]

Heya! We were having some failures in the testsuite at the base branch. Could you rebase this PR, make sure tests pass and mark for review again? Thanks!

[mateusjatenee]

@driesvints yessir!

[saade]

@driesvints @taylorotwell The deprecation of the api rate limiter is not documented anywhere? Or am i just being dumb here?

Getting: Rate limiter [api] is not defined. on a Laravel 11 app using ->throttleApi() + api middleware. It was working before on a v11.1.0 installation. Just updated to v11.3.1.

[mateusjatenee]

@saade is this an app you upgraded to 11? Do you have the api rate limiter defined in any service providers?
Prior to L11, it shipped by default on RouteServiceProvider

[saade]

@saade is this an app you upgraded to 11? Do you have the api rate limiter defined in any service providers? Prior to L11, it shipped by default on RouteServiceProvider

@mateusjatenee It is upgraded from L10 (using Shift), but it was running L11 perfectly in the last few weeks on a v11.1.0 installation. I think this is a BC for non-new apps?

[mateusjatenee]

@saade see this PR: #50818
The problem is it was previously just silently introducing undesired behavior. If a named limiter did not exist, it'd just default to 0 -- now it throws an exception.

[im-aeo]

RouteServiceProvider

Hey, Did you call your RouteServiceProvider in the bootstrap/providers.php?

bootstrap/providers.php

return [
    App\Providers\AppServiceProvider::class,
    App\Providers\RouteServiceProvider::class, // <--
];


RouteServiceProvider.php
<?php

namespace App\Providers;
use Illuminate\Cache\RateLimiting\Limit;
use Illuminate\Foundation\Support\Providers\RouteServiceProvider as ServiceProvider;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\RateLimiter;
use Illuminate\Support\Facades\Route;

use function PHPSTORM_META\elementType;

class RouteServiceProvider extends ServiceProvider
{
    /**
     * The path to your application's "home" route.
     *
     * Typically, users are redirected here after authentication.
     *
     * @var string
     */
    public const HOME = '/my/dashboard';

    /**
     * Define your route model bindings, pattern filters, and other route configuration.
     */
    public function boot(): void
    {
        $this->configureRateLimiter();

        $this->routes(function () {
            Route::middleware('api')
                ->prefix('api')
                ->as('api.')
                ->group(base_path('routes/api.php'));

            Route::middleware('web')
                ->group(base_path('routes/careers.php'));


            Route::middleware('web')
                ->group(base_path('routes/web.php'));
        });
    }

    protected function configureRateLimiter()
    {
        RateLimiter::for('api', function (Request $request) {
            return Limit::perMinute(60)->by($request->user()?->id ?: $request->ip());
        });
    }
}