[11.x] Better database creation failure handling #50836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
nunomaduro
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you try to migrate and your database isn't created yet, you'll be prompted to create it. However, if you choose to not do that, the migrate command will still continue to attempt to run database queries even though we know the database doesn't exists. This PR improves this flow by throwing an early exception to indicate the database couldn't be created and no subsequent queries are made anymore.
It's important to note that this PR doesn't changes behaviour as the user was already getting an exception. It's now just an informative message instead of the below query exception.
I stumbled upon this when running the Laravel installer to setup a new Jetstream app and wondered what would happen if I choose to not create the database.