[10.x] Fix cursor paginate with union and column alias #50809
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using cursorPaginate on a query with a union the where clause on the union uses the wrong column name.
Table Post:
Table News:
Post::toBase()->select('id', 'start_time as created_at')->union(News::toBase()->select('id', 'created_at'))->orderBy('created_at')->cursorPaginate(10, ['created_at']);
Should sort Post by the start_time column and News by thecreated_at column.
The current implementation sorts both Post and News by the start_time column.
This is similar to #50796 but applied against 10.x