Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Make DB::usingConnection() respect read/write type #50806

Merged
merged 2 commits into from
Mar 28, 2024
Merged

[11.x] Make DB::usingConnection() respect read/write type #50806

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8696328
Resolving default connection name before parsing it
SajtiDH Mar 28, 2024
8de13f3
formatting
taylorotwell Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Illuminate/Database/DatabaseManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ public function __construct($app, ConnectionFactory $factory)
*/
public function connection($name = null)
{
[$database, $type] = $this->parseConnectionName($name);
$name = $name ?: $this->getDefaultConnection();

$name = $name ?: $database;
[$database, $type] = $this->parseConnectionName($name);

// If we haven't created this connection, we'll create it based on the config
// provided in the application. Once we've created the connections we will
Expand Down