[11.x] signature typo

[abrahamgreyson]

One single Illuminate\Routing\Controllers\Middleware instance may break the request

[crynobone]

wouldn't array become redundant here?

[abrahamgreyson]

stupid me

[freshnewuniquename]

The updated type from this MR seems to differ from the allowed array element types given in the 2nd and 3rd official docs (master branch) examples of the middleware function return value.

Examples extracted from the docs

<?php
 
namespace App\Http\Controllers;
 
use App\Http\Controllers\Controller;
use Illuminate\Routing\Controllers\HasMiddleware;
use Illuminate\Routing\Controllers\Middleware;
 
class UserController extends Controller implements HasMiddleware
{
    /**
     * Get the middleware that should be assigned to the controller.
     */
    public static function middleware(): array
    {
        return [
            'auth',
            new Middleware('log', only: ['index']),
            new Middleware('subscribed', except: ['store']),
        ];
    }
 
    // ...
}

use Closure;
use Illuminate\Http\Request;
 
/**
 * Get the middleware that should be assigned to the controller.
 */
public static function middleware(): array
{
    return [
        function (Request $request, Closure $next) {
            return $next($request);
        },
    ];
}

Would a type like this fit better?

     /**
      * Get the middleware that should be assigned to the controller.
      *
-     * @return \Illuminate\Routing\Controllers\Middleware[]
+     * @return (\Illuminate\Routing\Controllers\Middleware|Closure|string)[]
      */
     public static function middleware();

[abrahamgreyson]

You are correct