Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix(ScheduleListCommand): fix doc block for listEvent method #50638

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

saMahmoudzadeh
Copy link
Contributor

This PR, update doc block for listEvent method in ScheduleListCommand.php

/**
     * List the given even in the console.
     *
     * @param  \Illuminate\Console\Scheduling\Event
     * @param  int  $terminalWidth
     * @param  array  $expressionSpacing
     * @param  int  $repeatExpressionSpacing
     * @param  array  $repeatExpressionSpacing
     * @param  \DateTimeZone  $timezone
     * @return \Illuminate\Support\DateTimeZone
     */
    private function listEvent($event, $terminalWidth, $expressionSpacing, $repeatExpressionSpacing, $timezone)
    {
  • add $event as first parameter to doc block
  • remove @param array $repeatExpressionSpacing
  • since the output of this method is explicitly an array, we should have @return array.

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@saMahmoudzadeh saMahmoudzadeh marked this pull request as ready for review March 19, 2024 02:58
@driesvints driesvints merged commit 14c8e95 into laravel:11.x Mar 19, 2024
30 checks passed
@driesvints
Copy link
Member

Thanks!

@saMahmoudzadeh saMahmoudzadeh deleted the fix/doc_block_schedult_list branch March 19, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants