Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Use default collation available from each Database Drivers #50544

Closed
wants to merge 2 commits into from

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Mar 14, 2024

Improvements from #50168 and laravel/laravel#6241

Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone changed the title Use default collation available from each Database Driver. [11.x] Use default collation available from each Database Drivers Mar 14, 2024
@crynobone crynobone marked this pull request as ready for review March 14, 2024 06:52
@Jubeki
Copy link
Contributor

Jubeki commented Mar 14, 2024

Probably not a good idea for MySQL 5.7 because this means, that the default collation is latin1_swedish_ci.

(The results from the previous PR were from MySQL 8.0 and MariaDB 10.11).

Maybe it's best to revert to utf8mb4_unicode_ci and make these changes for Laravel 12. The problem are developers using XAMPP or Laragon, who are dependent on the provided Database version and probably don't know how to update to a specific version.

@crynobone crynobone closed this Mar 14, 2024
@crynobone crynobone deleted the null-collation branch March 14, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants