[11.x] Fix crash when configuration directory is non-existing #50537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buismaarten
changed the title
tisnamuliarta
referenced
this pull request
in tisnamuliarta/laravel-shadcn
Mar 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [laravel/framework](https://laravel.com) ([source](https://togithub.com/laravel/framework)) | `11.0.5` -> `11.0.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>laravel/framework (laravel/framework)</summary> ### [`v11.0.8`](https://togithub.com/laravel/framework/compare/v11.0.7...v11.0.8) [Compare Source](https://togithub.com/laravel/framework/compare/v11.0.7...v11.0.8) ### [`v11.0.7`](https://togithub.com/laravel/framework/blob/HEAD/CHANGELOG.md#v1107---2024-03-15) [Compare Source](https://togithub.com/laravel/framework/compare/v11.0.6...v11.0.7) - \[11.x] Re-add translations for ValidationException by [@​driesvints](https://togithub.com/driesvints) in [https://github.com/laravel/framework/pull/50546](https://togithub.com/laravel/framework/pull/50546) - \[11.x] Removes unused Dumpable trait by [@​OussamaMater](https://togithub.com/OussamaMater) in [https://github.com/laravel/framework/pull/50559](https://togithub.com/laravel/framework/pull/50559) - \[11.x] Fix withRouting docblock type by [@​santigarcor](https://togithub.com/santigarcor) in [https://github.com/laravel/framework/pull/50563](https://togithub.com/laravel/framework/pull/50563) - \[11.x] Fix docblock in FakeInvokedProcess.php by [@​saMahmoudzadeh](https://togithub.com/saMahmoudzadeh) in [https://github.com/laravel/framework/pull/50568](https://togithub.com/laravel/framework/pull/50568) - \[11.x] fix: Add missing InvalidArgumentException import to Database/Schema/SqlServerBuilder by [@​ayutaya](https://togithub.com/ayutaya) in [https://github.com/laravel/framework/pull/50573](https://togithub.com/laravel/framework/pull/50573) - \[11.x] Improved translation for displaying the count of errors in the validation message by [@​andrey-helldar](https://togithub.com/andrey-helldar) in [https://github.com/laravel/framework/pull/50560](https://togithub.com/laravel/framework/pull/50560) - \[11.x] Fix retry_after to be an integer by [@​driesvints](https://togithub.com/driesvints) in [https://github.com/laravel/framework/pull/50580](https://togithub.com/laravel/framework/pull/50580) - \[11.x] Use available `getPath()` instead of using `app_path()` to detect if base controller exists by [@​crynobone](https://togithub.com/crynobone) in [https://github.com/laravel/framework/pull/50583](https://togithub.com/laravel/framework/pull/50583) - \[11.x] Fix doc block: `[@return](https://togithub.com/return) static` has been modified to `[@return](https://togithub.com/return) void` by [@​saMahmoudzadeh](https://togithub.com/saMahmoudzadeh) in [https://github.com/laravel/framework/pull/50592](https://togithub.com/laravel/framework/pull/50592) - accept attributes for channels by [@​taylorotwell](https://togithub.com/taylorotwell) in laravel/framework@398f494 ### [`v11.0.6`](https://togithub.com/laravel/framework/blob/HEAD/CHANGELOG.md#v1106---2024-03-14) [Compare Source](https://togithub.com/laravel/framework/compare/v11.0.5...v11.0.6) - \[11.x] Fix version constraints for illuminate/process by [@​riesjart](https://togithub.com/riesjart) in [https://github.com/laravel/framework/pull/50524](https://togithub.com/laravel/framework/pull/50524) - \[11.x] Update Broadcasting Install Command With Bun Support by [@​HDVinnie](https://togithub.com/HDVinnie) in [https://github.com/laravel/framework/pull/50525](https://togithub.com/laravel/framework/pull/50525) - \[11.x] Allows to comment `web` and `health` routes by [@​nunomaduro](https://togithub.com/nunomaduro) in [https://github.com/laravel/framework/pull/50533](https://togithub.com/laravel/framework/pull/50533) - \[11.x] Add generics for Arr::first() by [@​phh](https://togithub.com/phh) in [https://github.com/laravel/framework/pull/50514](https://togithub.com/laravel/framework/pull/50514) - Change default collation for MySQL by [@​driesvints](https://togithub.com/driesvints) in [https://github.com/laravel/framework/pull/50555](https://togithub.com/laravel/framework/pull/50555) - \[11.x] Fixes install:broadcasting command by [@​joedixon](https://togithub.com/joedixon) in [https://github.com/laravel/framework/pull/50550](https://togithub.com/laravel/framework/pull/50550) - \[11.x] Fix crash when configuration directory is non-existing by [@​buismaarten](https://togithub.com/buismaarten) in [https://github.com/laravel/framework/pull/50537](https://togithub.com/laravel/framework/pull/50537) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tisnamuliarta/laravel-shadcn). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Laravel configuration files are no longer necessarily needed in the skeleton, some may want to delete the configuration directory entirely.
When the configuration directory is omitted, Laravel crashes using the following error:
The error occurs because
$configPath = realpath($app->configPath());returnsfalse, this triggers a Exception becausefalseis not a directory that can be found.This PR solves this problem where the configuration directory can be omitted without crash.