Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Improved exception message on 'ensure' method #50517

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[11.x] Improved exception message on 'ensure' method #50517

merged 1 commit into from
Mar 13, 2024

Conversation

fgaroby
Copy link
Contributor

@fgaroby fgaroby commented Mar 13, 2024 •
edited
Loading

This PR improves the returned message, when the Collection::ensure method throws an UnexpectedValueException.
For now on, we know what position (0-based index) the wrong value is.

- Collection should only include [stdClass] items, but 'string' found.
+ Collection should only include [stdClass] items, but 'string' found at position 3.

@driesvints driesvints changed the title Improved exception message on 'ensure' method [11.x] Improved exception message on 'ensure' method Mar 13, 2024
@taylorotwell taylorotwell merged commit c844b22 into laravel:11.x Mar 13, 2024
30 checks passed
This was referenced May 28, 2024
Closed
Closed
Open
Open
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgaroby @taylorotwell