[11.x] Fix: Removed TTY mode to resolve Windows compatibility issue #50495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yourchocomate
changed the title
crynobone
reviewed
Mar 13, 2024
src/Illuminate/Foundation/Console/BroadcastingInstallCommand.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Mior Muhammad Zaki <[email protected]>
driesvints
reviewed
Mar 13, 2024
src/Illuminate/Foundation/Console/BroadcastingInstallCommand.php
Outdated
Show resolved
Hide resolved
menglisch
reviewed
Mar 13, 2024
driesvints
reviewed
Mar 13, 2024
driesvints
approved these changes
Mar 13, 2024
driesvints
reviewed
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: RuntimeException - TTY mode is not supported on Windows platform.
Description
This PR addresses a compatibility issue on Windows platforms where TTY mode is not supported. The issue arises in the installNodeDependencies() function, where TTY mode is set unnecessarily. This setting triggers a Symfony\Component\Process\Exception\RuntimeException due to unsupported TTY mode on Windows.
Changes Made