Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Allow Expression at more places in Query Builder #50402

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[10.x] Allow Expression at more places in Query Builder #50402

merged 1 commit into from
Mar 7, 2024

Conversation

pascalbaljet
Copy link
Contributor

The code below causes PHPStan errors because the second argument is an Expression instance. The instance will eventually be transformed in Grammer::whereColumn(), so this should be allowed.

DB::table('users', 't1')->leftJoin('users AS t2', DB::raw('t1.uid + 1'), '=', 't2.uid');

I added the Expression class to more docblocks to solve this. This relates to #46160

@pascalbaljet pascalbaljet changed the title Allow Expression at more places in Query Builder [10.x] Allow Expression at more places in Query Builder Mar 7, 2024
@taylorotwell taylorotwell merged commit 745b205 into laravel:10.x Mar 7, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants