Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the work done by @daylerees in #4948. See that PR for more info.
It basically allows any type that
settype
accepts, plusdate
(not sure how usefularray
,object
andnull
could be. Maybe we should prevent that?).This improves upon @daylerees's work thus:
SoftDeletingTrait
to castdeleted_at
to a date (it had been working automatically in 4.1 and has been restored here).There are no tests yet.
I'm trying to get a consensus about what people think of this implementation and if @taylorotwell thinks this should be added (and whether to 4.2 or 4.3).
Once everything is ironed out I'll be more than happy to write the tests.